Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize initialization of PMW3360 Sensor #15821

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Optimize initialization of PMW3360 Sensor #15821

merged 2 commits into from
Jan 10, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 10, 2022

Description

Let the SPI driver handle uploading the full firmware blob. This procduces a faster init, especially as it was using waits.

Retains old behavior in case there are issues. However, tested on both F411 blackpill and ploopy mouse (8MHz atmega32u4) without any issues.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 10, 2022 18:32
@drashna drashna merged commit ec7c3ac into qmk:develop Jan 10, 2022
@drashna drashna deleted the core/pmw_init branch January 10, 2022 22:57
0xcharly added a commit to 0xcharly/qmk_firmware that referenced this pull request Feb 6, 2022
@0xcharly
Merge 2 PR to improve blackpill boot time
8c7b1d7 
- qmk#15805: [Core] ChibiOS: shorten USB disconnect state on boot to 50ms
- qmk#15821: Optimize initialization of PMW3360 Sensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark